Autopilot goes from VOR to ROLL when tracking VOR

Black Square

@MarkS Give this a try I'm not sure exactly what this will do, but it should be a good place to start.

<UseTemplate Name="ASOBO_GT_Update">
	<FREQUENCY>1</FREQUENCY>
	<UPDATE_CODE>
		(A:AUTOPILOT MASTER, bool) (O:lastApNavMode) (A:AUTOPILOT BANK HOLD, Bool) (A:AUTOPILOT WING LEVELER, Bool) or and and if{
			1 (&gt;L:var_AutopilotDisconnectTone, bool)
		}
		(A:AUTOPILOT NAV1 LOCK, bool) (&gt;O:lastApNavMode)
	</UPDATE_CODE>
</UseTemplate>

MarkS

@Black-Square said in Autopilot goes from VOR to ROLL when tracking VOR:

@MarkS Give this a try I'm not sure exactly what this will do, but it should be a good place to start.

Thank you. Any particular location in the Flight Director code section you'd recommend to put it?

Black Square

You can drop that anywhere in the file between other <UseTemplate Name="ASOBO_GT_Update"> tags. For instance, right after the  comment.

MarkS

@Black-Square I'll give it a go. I suppose it could be dropped in anywhere but in good practice it ought to be at least near the other relevant functionality.

(P.S. as hard as it is for me to parse RPN, your code is a treat to work with for this old automation engineer).

MarkS

@Black-Square no joy.

According to an Axes and Ohs watch list I set up to monitor, it appears the O:lastApNavMode variable isn't getting updated,(what is an O variable anyway?), or perhaps Axes and Ohs isn't capable yet of seeing it. I can declare it in the watch list, and it appears, but that doesn't necessarily mean there's communication to it.

I did a test flight with two VORs and deliberately flew through their zone 'o' confusion to force a failover from NAV to ROLL. Which happened as expected, but no alarm.

In fact, the AUTOPILOT BANK HOLD and AUTOPILOT WING LEVELER are never '1' at any point in during flight testing, and I'm not sure if it's something I'm doing or not doing or its just one of those weird things that are out of our hands like state saving.

This tickles my old engineering brain a little and I'm tempted to take a crack at it. I'm wondering if I can just declare a var in the interior.xml that Axes and Ohs can (demonstrably) see, to replace the O var. Maybe Mr Occam had a nice shave and will smile kindly on my attempt.

Here's the sequence with the Axes and Ohs watch lists.

Black Square

O:Vars are local to the scope of that UseTemplate tag, but if you just replace the O with an L, that should make it globally visible.

Do I misunderstand your message, or is AUTOPILOT BANK HOLD true in your last screenshot, right when we expect it to be?

I don't see anything wrong with the code, but I can test it when I'm next working in the simulator. Can you show me where you inserted it into the file?

MarkS

@Black-Square said in Autopilot goes from VOR to ROLL when tracking VOR:

Do I misunderstand your message, or is AUTOPILOT BANK HOLD true in your last screenshot, right when we expect it to be?

No, that's on me, I missed that it was set. Nice catch. Interesting though, that Wing Leveler is never true.

I put the new code at the top of the Flight Director section (I was bold and already changed the O to an L but haven't had a chance to test it yet).

I sat with it for a bit afterwards and thought it might simplify to something like this (sorry for the infix pseudocode, can't "think" in RPN):

If
	A:AUTOPILOT_MASTER = True and L:lastApNavMode = True and A:AUTOPILOT_NAV1_LOCK = False
Then
	L:var_AutopilotDisconnectTone := 1
Endif
L:lastAPNavMode := A:AUTOPLOT_NAV1_LOCK

The RPN issue I have with the above is that the NAV1 LOCK comparator is (I think) an "and not" operation in RPN, and I don't know how to do that. I'm not entirely sure what BANK HOLD or WING LEVELER are bringing to the party, but you surely have a better handle on that than I.

MarkS

Against my better judgement, I came up with this refactoring of the infix pseudocode I proposed above:

<!-- Mark's Occam-Channeling Autopilot NAV to ROLL mode failover alarm (probably doesn't work) -->

<UseTemplate Name="ASOBO_GT_Update">
	<FREQUENCY>1</FREQUENCY>
	<UPDATE_CODE>
		(A:AUTOPILOT NAV1 LOCK, bool) (L:lastApNavMode) (A:AUTOPILOT MASTER, bool) not and and if {
			1 (&gt;L:var_AutopilotDisconnectTone, bool)
		}
		(A:AUTOPILOT NAV1 LOCK, bool) (&gt;L:lastApNavMode)
	</UPDATE_CODE>
</UseTemplate>

I looks almost right to my eye, but I still don't know if that 'and not' is legal. Guess I'll find out later. At least it's easy to remove if (when) it fails spectacularly.

Addendum: It didn't fail, but it didn't work either. @Black-Square shouldn't (L:lastApNavMode) be (L:lastApNavMode, bool) instead?

Black Square

The code was working, but the sound was only triggering once. Try this:

(L:var_AutopilotSource, bool) ! (L:var_ActiveNavSource_L, number) 2 &lt; and
(L:var_AutopilotSource, bool)   (L:var_ActiveNavSource_R, number) 2 &lt; and
or
(A:AUTOPILOT BANK HOLD, Bool) (A:AUTOPILOT WING LEVELER, Bool) or and
(A:AUTOPILOT MASTER, bool) and
if{
	(L:lastApNavMode, bool) if{
		1 (&gt;L:var_AutopilotDisconnectTone, bool)
	}
	els{
		0 (&gt;L:var_AutopilotDisconnectTone, bool)
	}
}
(A:AUTOPILOT NAV1 LOCK, bool) (&gt;L:lastApNavMode, bool)

I added some extra features for you while I was at it. It should only trigger when you're using VOR navigation now too.

Thanks for putting me back in Starship for just a couple minutes. What an absolutely magnificent machine.

MarkS

@Black-Square said in Autopilot goes from VOR to ROLL when tracking VOR:

Thanks for putting me back in Starship for just a couple minutes. What an absolutely magnificent machine.

Indeed it is, and I'll have more to say on that in another thread. But for openers...

YES! YES! Happy dance underway. It works! Gave me a bit of a scare, as I'd forgotten to update layout.json after editing the interior.xml, and the first time I loaded in, the cockpit had been eaten! After a brief moment of panic, I got that sorted.

A couple of quick tests near my local VOR (it's still weird to me flying Starship near my home), and we have a winner! Here's the test results:

NAV-ROLL Failover - Enhanced Version - Functional Test

Test environment:
Win 11, MSFS 2024
Departure: KRDG
Destination: KPHL
Intermediate VOR: PTW 116.50, CRS 126 deg, 21 nm from KRDG

Nav preset and pre-selected prior to departure.

Autopilot engaged, NAV in FMS mode, climbing to altitude (3500 AGL)

Autopilot engaged, NAV in FMS mode, ALT mode engaged

Autopilot engaged, NAV in VOR mode, tracking inbound to VOR, ALT mode engaged

Autopilot engaged, overflew VOR, failover to ROLL mode (cone 'o' confusion), ALT mode engaged.

The only change I would make, is to keep the disconnect alarm sounding until silenced by the pilot, just like a normal autopilot disconnect, rather than the one-shot alarm that's in there now. It is easy to miss, like the MDA alarm (at least for me).

Next step for me is to roll this into my "personalization" mod where I've changed a few things to better suit how I'd leave the plane if I actually owned one. (I would pay genuine cash money just for the opportunity to sit in the cockpit and preflight one of these for real.)

Although I've not experienced this in any of your other aircraft, this should be adaptable into the Caravan's interior.xml for those experiencing the issue there, would you agree?